Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI-80: users blocks commands #219

Merged
merged 9 commits into from
Apr 23, 2021
Merged

CLI-80: users blocks commands #219

merged 9 commits into from
Apr 23, 2021

Conversation

mhsu-auth0
Copy link
Contributor

@mhsu-auth0 mhsu-auth0 requested a review from Widcket April 1, 2021 05:58
Widcket
Widcket reviewed Apr 2, 2021
View reviewed changes
internal/cli/users.go Outdated Show resolved Hide resolved
Widcket
Widcket reviewed Apr 2, 2021
View reviewed changes
internal/cli/users.go Outdated Show resolved Hide resolved
Widcket
Widcket reviewed Apr 2, 2021
View reviewed changes
internal/cli/users.go Outdated Show resolved Hide resolved
Widcket
Widcket reviewed Apr 2, 2021
View reviewed changes
internal/cli/users.go Outdated Show resolved Hide resolved
Widcket
Widcket previously requested changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just need some adjustments 💪🏻 . Please ask the user to input the user ID, and have the delete command be users unblock.

@mhsu-auth0 mhsu-auth0 requested a review from Widcket April 23, 2021 21:30
cyx
cyx reviewed Apr 23, 2021
View reviewed changes
internal/auth/auth.go
@@ -30,7 +30,7 @@ var requiredScopes = []string{
"create:clients", "delete:clients", "read:clients", "update:clients",
"create:resource_servers", "delete:resource_servers", "read:resource_servers", "update:resource_servers",
"create:rules", "delete:rules", "read:rules", "update:rules",
"read:client_keys", "read:logs",
"read:client_keys", "read:logs", "read:users", "update:users",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, deleting user blocks only require update:users

cyx
cyx reviewed Apr 23, 2021
View reviewed changes
internal/cli/root.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Apr 23, 2021
View reviewed changes
internal/cli/users.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Apr 23, 2021
View reviewed changes
internal/cli/users.go Outdated Show resolved Hide resolved
cyx
cyx reviewed Apr 23, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on Flag vs Argument.

@mhsu-auth0 mhsu-auth0 requested a review from cyx April 23, 2021 23:02
cyx
cyx approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@cyx cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work!

@mhsu-auth0 mhsu-auth0 dismissed Widcket’s stale review April 23, 2021 23:07

Completed changes

@mhsu-auth0 mhsu-auth0 merged commit 7263e5a into main Apr 23, 2021
@mhsu-auth0 mhsu-auth0 deleted the user-blocks branch April 23, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyx cyx cyx approved these changes

@Widcket Widcket Awaiting requested review from Widcket

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsu-auth0 @cyx @Widcket